Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHA3 word cost for CREATE2 #17812

Merged
merged 3 commits into from
Oct 5, 2018
Merged

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Oct 2, 2018

This adds a per-word cost to CREATE2, as discussed in https://gitter.im/ethereum/AllCoreDevs?at=5bb315de6e5a401c2d037971

@holiman holiman requested a review from karalabe as a code owner October 2, 2018 12:23
@holiman holiman changed the title Create2addresstest SHA3 word cost for CREATE2 Oct 2, 2018
@holiman
Copy link
Contributor Author

holiman commented Oct 5, 2018

Parity has merged their corresponding one: openethereum/parity-ethereum#9694

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit 092df3a into ethereum:master Oct 5, 2018
gballet pushed a commit to gballet/go-ethereum that referenced this pull request Oct 5, 2018
* core/vm: create2 address generation tests

* core/vm: per byte cost of CREATE2

* core/vm: fix linter issue in test
cryptomental pushed a commit to cryptomental/go-ethereum that referenced this pull request Jan 9, 2019
* core/vm: create2 address generation tests

* core/vm: per byte cost of CREATE2

* core/vm: fix linter issue in test
cryptomental pushed a commit to cryptomental/go-ethereum that referenced this pull request Jan 9, 2019
* core/vm: create2 address generation tests

* core/vm: per byte cost of CREATE2

* core/vm: fix linter issue in test
cryptomental pushed a commit to cryptomental/go-ethereum that referenced this pull request Jan 9, 2019
* core/vm: create2 address generation tests

* core/vm: per byte cost of CREATE2

* core/vm: fix linter issue in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants