les: remove support for LES/1 #19403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
approved these changes
Apr 6, 2019
There was a problem hiding this comment.
Generally, this PR is good to me, especially we finally convert the CHT size from 4096 to 32768 in the server side. Also, this PR rename the CHT store prefix so that we can discard the old CHT data in the server side quietly, it's really good.
Only a few nitpicks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes support for LES/1 protocol messages and the old 4096 block CHT size.
Note: changing the section size of the CHT indexer requires regeneration of the CHTs. They could have been converted with an extra db conversion but the point of this PR is to remove extra logic, not add more. I considered recalculation the safer and much easier option (it only takes a few minutes). The CHT trie database is left in its old place and it does not change (only the index) so no significant amount of waste is left in the database. I also cross-tested checkpoint syncing between master and this branch.