Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

les: remove support for LES/1 #19403

merged 2 commits into from Apr 8, 2019


None yet
2 participants
Copy link

commented Apr 5, 2019

This PR removes support for LES/1 protocol messages and the old 4096 block CHT size.

Note: changing the section size of the CHT indexer requires regeneration of the CHTs. They could have been converted with an extra db conversion but the point of this PR is to remove extra logic, not add more. I considered recalculation the safer and much easier option (it only takes a few minutes). The CHT trie database is left in its old place and it does not change (only the index) so no significant amount of waste is left in the database. I also cross-tested checkpoint syncing between master and this branch.

@zsfelfoldi zsfelfoldi added the pr:review label Apr 5, 2019

@zsfelfoldi zsfelfoldi added this to the 1.9.0 milestone Apr 5, 2019

Copy link

left a comment

Generally, this PR is good to me, especially we finally convert the CHT size from 4096 to 32768 in the server side. Also, this PR rename the CHT store prefix so that we can discard the old CHT data in the server side quietly, it's really good.

Only a few nitpicks.

Show resolved Hide resolved les/handler_test.go Outdated
Show resolved Hide resolved les/odr_requests.go
Show resolved Hide resolved les/odr_requests.go
Show resolved Hide resolved les/peer.go
Show resolved Hide resolved les/handler_test.go Outdated

@zsfelfoldi zsfelfoldi force-pushed the zsfelfoldi:remove-les1 branch from f05cce2 to 64f9c1e Apr 8, 2019

@zsfelfoldi zsfelfoldi merged commit 7c08e48 into ethereum:master Apr 8, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.