Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm/api/http: fix bzz-hash to return ens resolved hash directly #19594

Merged
merged 1 commit into from
May 28, 2019

Conversation

acud
Copy link
Member

@acud acud commented May 17, 2019

This PR fixes a small bug where a requested ENS name with bzz-hash would return a 404 when the underlying hash that was pointed to does not exist. It will now return the hash that is pointed to by the ENS entry without asserting its existence on Swarm.

fixes ethersphere/swarm#1401

@acud acud requested review from nonsense and zelig May 17, 2019 19:10
@acud acud self-assigned this May 17, 2019
@nonsense nonsense merged commit 008d250 into ethereum:master May 28, 2019
@acud acud deleted the http-no-404-hash branch June 3, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bzz-hash should not fail on root chunk missing
2 participants