les: handler separation #19639
les: handler separation #19639
Conversation
rjl493456442
requested review from
fjl,
gballet,
holiman,
karalabe and
zsfelfoldi
as code owners
rjl493456442
force-pushed
the
les-refactor-3
branch
4 times, most recently
from
4bbc4ac
to
e5ff2cd
Compare
rjl493456442
force-pushed
the
les-refactor-3
branch
3 times, most recently
from
f02b6ab
to
b79d16b
Compare
rjl493456442
force-pushed
the
les-refactor-3
branch
from
b79d16b
to
8b05adb
Compare
rjl493456442
force-pushed
the
les-refactor-3
branch
from
8b05adb
to
b598746
Compare
|
@zsfelfoldi Could you please take a look when you back :) This PR basically separates the client handler and server handler into two structures so that it's easier to read. Besides in the server handler, this PR replaces some direct disk access with cached enabled approach( |
rjl493456442
force-pushed
the
les-refactor-3
branch
2 times, most recently
from
389e104
to
3aab5a3
Compare
rjl493456442
force-pushed
the
les-refactor-3
branch
from
3aab5a3
to
eb55adf
Compare
There was a problem hiding this comment.
Most of the PR looks good. It is hard to judge the correctness of such a huge refactoring though. Please take another look at the server handler (accept and sendResponse fns in particular) because there are some changes that I am not sure about. If it is just out of sync with latest master then please fix it, otherwise comment why those changes have been made. It is a really sensitive part of the code.
rjl493456442
force-pushed
the
les-refactor-3
branch
from
9bd903c
to
f72f115
Compare
|
@zsfelfoldi I address the comments. I know it's super hard to review such a huge refactor PR. I review it a few times and do it again today. I think it should sync with master branch. But really hope you can check it again to ensure this PR doesn't break something :)) Btw there is a tiny conflict with master branch(it's only 2 line change I made a few days ago). I would leave it now. Since I always squash all commits and then rebase. I think the commit I made today probably will make it easier for you to catch all changes. |
core: address comments les: address comments les: fix metrics
rjl493456442
force-pushed
the
les-refactor-3
branch
from
3f1a4f7
to
77ae572
Compare
|
@zsfelfoldi Fixed and rebased. The fix is in the last commit. |
rjl493456442
force-pushed
the
les-refactor-3
branch
from
4d35807
to
ec616b5
Compare
rjl493456442
force-pushed
the
les-refactor-3
branch
from
ec616b5
to
1865e5f
Compare
This PR refactors light client handler a bit by separating the client handler and server handler to two structures.