swarm/network/stream: remove dead code #19650
Conversation
| @@ -474,7 +474,7 @@ type server struct { | |||
| // setNextBatch adjusts passed interval based on session index and whether | |||
There was a problem hiding this comment.
@justelad I think we should extract this logic and have it unit tested. Basically the functionality which adjusts the input intervals and uses the adjusted intervals is not clear and not tested, which is weird, as there are very little input parameters to it:
- from
- to
- sessionIndex
- stream type (live or history)
This should have been unit tested, at least for the purpose of documentation.
There was a problem hiding this comment.
this function should not even exist IMO. not sure why we would ever want to override a value. e.g. when syncing is live and from is 0... but i think that with the first offered hashes msg the client already gets the actual session index from the server with the from range specified on the message. a lot of the code here is not needed, some of it also should return errors directly (which it doesn't)
nonsense
force-pushed
the
remove-dead-code-again
branch
from
fc6dcb5
to
e9f4d1a
Compare
|
This will be continued at https://github.com/ethersphere/swarm |
This PR is removing dead code, which only increases complexity and is not used currently.
The P2P message serialised and sent across the wire is changing, as we no longer have
HandoverProof, so I should check if this is backward compatible - not really sure how RLP marshal/unmarshal works in this case.Apart from that, code used in production is equivalent before/after this PR.
This code has been in the codebase for a year. As a general rule-of-thumb, we should not be adding code to the codebase that is not directly used, or that we won't be using shortly after introduced, because this increases complexity and introduces unnecessary indirection.