Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fourbyte: updates #19957

Merged
merged 2 commits into from
Aug 19, 2019
Merged

fourbyte: updates #19957

merged 2 commits into from
Aug 19, 2019

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Aug 13, 2019

New signatures from ethereum/lists

@karalabe
Copy link
Member

Hmmmm.... this is a 12MB diff. Wondering whether we should replace the json with a formatted one and disable compression on the binary version. Otherwise every tiny addition we make will bring along 12MB worth of repo size, and we'll run out of allowance (not to mention it's annoying that we're already at 500MB repo size).

@holiman
Copy link
Contributor Author

holiman commented Aug 13, 2019

I'm sorry, I don't understand what you mean with "replace the json with a formatted one and disable compression on the binary". Elaborate?
Ah, you mean to keep the git diffs smaller. So you mean sort the json by key, and use linebreaks, and then not use compression. Yeah might be better

@holiman
Copy link
Contributor Author

holiman commented Aug 13, 2019

Yes, that would also make it humanly possible to actually meaningfully review the PRs

@holiman
Copy link
Contributor Author

holiman commented Aug 13, 2019

This is now fixed, so the json file is sorted by key and not compressed. This time the diff will be big, but later diffs will be smaller.

@karalabe karalabe added this to the 1.9.3 milestone Aug 14, 2019
@holiman
Copy link
Contributor Author

holiman commented Aug 19, 2019

Travis errror on one of the jobs is unrelated

 --- FAIL: TestClientNotificationStorm (2.29s)
    client_test.go:378: didn't get expected error 

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit 7d3b260 into ethereum:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants