-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fourbyte: updates #19957
fourbyte: updates #19957
Conversation
Hmmmm.... this is a 12MB diff. Wondering whether we should replace the json with a formatted one and disable compression on the binary version. Otherwise every tiny addition we make will bring along 12MB worth of repo size, and we'll run out of allowance (not to mention it's annoying that we're already at 500MB repo size). |
I'm sorry, I don't understand what you mean with "replace the json with a formatted one and disable compression on the binary". Elaborate? |
Yes, that would also make it humanly possible to actually meaningfully review the PRs |
This is now fixed, so the json file is sorted by key and not compressed. This time the diff will be big, but later diffs will be smaller. |
Travis errror on one of the jobs is unrelated
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
New signatures from ethereum/lists