Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd, core, eth, les: support --override.istanbul #20004

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

karalabe
Copy link
Member

This is a clone of #18273 to support overriding the Istanbul fork block until it passes.

@karalabe karalabe added this to the 1.9.3 milestone Aug 23, 2019
@karalabe karalabe requested a review from holiman August 23, 2019 09:10
@karalabe karalabe mentioned this pull request Aug 23, 2019
10 tasks
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit cc9eb91 into ethereum:master Aug 23, 2019
@captain-kark
Copy link

I am adding this flag to my k8s stateful set as a backup (commented out) in case it needs to be updated quickly. Would this be the correct way to use this feature?

          # if the istanbul hardfork gets delayed, uncomment this
          # to buy time until approximately January 6th, 2020
          # - --override.istanbul
          # - 9250000

Should there be an issue, uncomment this setting, and redeploy to rewind a few blocks and continue for four more weeks...if it goes well, delete this commented out section and continue as normal.

I wasn't able to find an official block height for January 6th, but I assume this would be good enough until more information was released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants