Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethstats: fix URL parser for '@' or ':' in nodename #21640

Merged
merged 3 commits into from May 25, 2021
Merged

ethstats: fix URL parser for '@' or ':' in nodename #21640

merged 3 commits into from May 25, 2021

Commits on Sep 29, 2020

  1. ethstats: extract parse url fn, create unit test (which fails) 

    Signed-off-by: meows <b5c6@protonmail.com>
    @meowsbits
    meowsbits committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    cd13b05 View commit details
    Browse the repository at this point in the history

  2. ethstats: fix ethstats url parsing to handle values with special chars 

    Signed-off-by: meows <b5c6@protonmail.com>
    @meowsbits
    meowsbits committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    05df0e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. ethstats: do not require ':' in nodename/+pass section 

    Addresses review ethereum#21640 (review)

Signed-off-by: meows <b5c6@protonmail.com>
    @meowsbits
    meowsbits committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    87e6d22 View commit details
    Browse the repository at this point in the history