cmd/devp2p/internal/ethtest: add block hash announcement test #22535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
force-pushed
the
add-newBlockHash-ethtest
branch
from
4ec3738
to
1448da9
Compare
renaynay
force-pushed
the
add-newBlockHash-ethtest
branch
from
1448da9
to
393d2d5
Compare
renaynay
force-pushed
the
add-newBlockHash-ethtest
branch
from
393d2d5
to
9dce99f
Compare
renaynay
force-pushed
the
add-newBlockHash-ethtest
branch
2 times, most recently
from
c4c2d8c
to
413250a
Compare
renaynay
force-pushed
the
add-newBlockHash-ethtest
branch
from
413250a
to
fde5c52
Compare
fjl
changed the title
reds
pushed a commit
to reds/go-ethereum
that referenced
this pull request
Aug 28, 2021
i-norden
pushed a commit
to cerc-io/go-ethereum
that referenced
this pull request
Sep 10, 2021
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a block hash announcement test to the eth test suite for both eth protocol version 66 and 65 and below. The test sends a block hash announcement to the node, waits for the node to request the header, and from a separate connection, waits for either the block hash announcement or new block propagation from the node.