core: add change counter #23095
Merged
core: add change counter #23095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
reviewed
Jul 13, 2021
core/tx_pool.go
Outdated
| @@ -111,6 +111,7 @@ var ( | |||
| invalidTxMeter = metrics.NewRegisteredMeter("txpool/invalid", nil) | |||
| underpricedTxMeter = metrics.NewRegisteredMeter("txpool/underpriced", nil) | |||
| overflowedTxMeter = metrics.NewRegisteredMeter("txpool/overflowed", nil) | |||
| throttleTxMeter = metrics.NewRegisteredMeter("txpool/throttle", nil) | |||
There was a problem hiding this comment.
We could add a meter for the reorgs, then we could see how wildly we're spinning.
There was a problem hiding this comment.
We can add a few more metrics there too: how long reorgs take (timer), how many drops in between reorgs (hist), + whatnot the author wants :D
karalabe
reviewed
Jul 13, 2021
holiman
force-pushed
the
txpool_hysteresis
branch
from
7a5544e
to
3905561
Compare
|
This is now running on eu-west-1 |
|
Last 12 hours on bootnode eu-west-1
|
|
|
|
Here's a week In normal circumstances, we seem to never drop more than 1-2 txs between reorgs, so having the cap in place should not affect anything unless something is extremely abnormal. |
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Aug 25, 2021
* core: make txpool reject too sudden changes * core: add some metrics to txpool
reds
pushed a commit
to reds/go-ethereum
that referenced
this pull request
Aug 28, 2021
* core: make txpool reject too sudden changes * core: add some metrics to txpool
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
* core: make txpool reject too sudden changes * core: add some metrics to txpool
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 30, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 30, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 30, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 31, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a change-counter, to prevent too much from happening inside the pool before the pool has had a chance to run a reorg, which 'balances' the queued and pending transactions.