Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p/simulations: fix unlikely crash in probabilistic connect #23200

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

Evolution404
Copy link
Contributor

When the nodeCount is less than 10, it will panic with the out of bound error.
How about we just skip this round, when rand1 and rand2 are equal?

@Evolution404 Evolution404 requested a review from fjl as a code owner July 13, 2021 02:30
@fjl fjl changed the title simulations/mocker.go when it's equal, we just skip this round p2p/simulations: fix unlikely crash in probabilistic connect Jul 29, 2021
@fjl fjl merged commit 8f11d27 into ethereum:master Jul 29, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Aug 1, 2021
…m#23200)

When the nodeCount is less than 10, it will panic with the out of bound error.
How about we just skip this round, when rand1 and rand2 are equal?
reds pushed a commit to reds/go-ethereum that referenced this pull request Aug 28, 2021
…m#23200)

When the nodeCount is less than 10, it will panic with the out of bound error.
How about we just skip this round, when rand1 and rand2 are equal?
i-norden pushed a commit to cerc-io/go-ethereum that referenced this pull request Sep 10, 2021
…m#23200)

When the nodeCount is less than 10, it will panic with the out of bound error.
How about we just skip this round, when rand1 and rand2 are equal?
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
…m#23200)

When the nodeCount is less than 10, it will panic with the out of bound error.
How about we just skip this round, when rand1 and rand2 are equal?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants