eth/gasprice: avoid modifying TestChainConfig #23204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
requested review from
holiman,
karalabe and
rjl493456442
as code owners
fjl
reviewed
Jul 14, 2021
eth/gasprice/gasprice_test.go
Outdated
| } else { | ||
| gspec.Config.LondonBlock = nil | ||
| } | ||
| gspec.Config.LondonBlock = londonBlock |
There was a problem hiding this comment.
I also found it non-obvious in the original PR where this conditional got introduced.
With your change, the assignment of signer gets lost. This changes the outcome
because LatestSigner may choose another signer type if London is enabled.
Both your version and the original version have another issue: params.TestChainConfig
is modified without copying it first.
There was a problem hiding this comment.
Ah I didn't realize this. Would it make sense to copy the config, modify the LondonBlock, and then create the signer to remove the no-op here?
fjl
changed the title
fjl
approved these changes
Oct 10, 2021
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Oct 11, 2021
Co-authored-by: Felix Lange <fjl@twurst.com>
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 31, 2024
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 31, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 10, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 11, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 11, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 12, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 13, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 13, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 13, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 13, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 13, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 14, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 17, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 17, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 17, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 17, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 18, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up a no-op in the gasprice unit tests where a variable is overwritten in a conditional checking if it is nil or not, but the conditional is not necessary. In one branch, there is additionally a signer object that is overwritten, which will be identical to the one created and overwritten directly above it.