Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/devp2p/internal/ethtest: remove WriteTo method #23379

Merged
merged 2 commits into from
Aug 25, 2021
Merged

cmd/devp2p/internal/ethtest: remove WriteTo method #23379

merged 2 commits into from
Aug 25, 2021

Conversation

baptiste-b-pegasys
Copy link
Contributor

doing a go vet

go vet ./...
# github.com/ethereum/go-ethereum/cmd/devp2p/internal/ethtest
cmd/devp2p/internal/ethtest/chain.go:42:17: method WriteTo(writer io.Writer) error should have signature WriteTo(io.Writer) (int64, error)
# github.com/ethereum/go-ethereum/tests/fuzzers/trie
tests/fuzzers/trie/trie-fuzzer.go:72:23: method ReadByte() byte should have signature ReadByte() (byte, error)

Propose to fix the 1st one.

@fjl fjl changed the title ethtest: go vet warns of signature of unused function cmd/devp2p/internal/ethtest: remove WriteTo Aug 25, 2021
@fjl fjl changed the title cmd/devp2p/internal/ethtest: remove WriteTo cmd/devp2p/internal/ethtest: remove WriteTo method Aug 25, 2021
@fjl fjl merged commit 154b525 into ethereum:master Aug 25, 2021
@fjl fjl added this to the 1.10.9 milestone Aug 25, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Aug 25, 2021
@baptiste-b-pegasys
cmd/devp2p/internal/ethtest: remove WriteTo method (ethereum#23379)
cd92d2c 
WriteTo is unused, and go vet warns about it because it
doesn't match the usual signature of the io.WriterTo method.
reds pushed a commit to reds/go-ethereum that referenced this pull request Aug 28, 2021
@baptiste-b-pegasys
cmd/devp2p/internal/ethtest: remove WriteTo method (ethereum#23379)
acf053a 
WriteTo is unused, and go vet warns about it because it
doesn't match the usual signature of the io.WriterTo method.
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@baptiste-b-pegasys @zzyalbert
cmd/devp2p/internal/ethtest: remove WriteTo method (ethereum#23379)
4e44941 
WriteTo is unused, and go vet warns about it because it
doesn't match the usual signature of the io.WriterTo method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@baptiste-b-pegasys @fjl