Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: fix compilation for GOOS=js #23449

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Aug 24, 2021

This change is required to allow compilation of accounts/abi/bind to WebAssembly.

@fjl fjl added this to the 1.10.9 milestone Aug 24, 2021
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe karalabe merged commit a789dcc into ethereum:master Aug 24, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Aug 25, 2021
reds pushed a commit to reds/go-ethereum that referenced this pull request Aug 28, 2021
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants