Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-compliant verkle tree #23563

Closed
wants to merge 33 commits into from
Closed

EIP-compliant verkle tree #23563

wants to merge 33 commits into from

Conversation

gballet
Copy link
Member

@gballet gballet commented Sep 10, 2021 •
edited
Loading

This PR adds a --verkle switch that makes geth use verkle trees instead of the MPT.

Summary of the changes:

  • Merges the storage and account trees (in a verkle context only)
  • Separate the tree root calculation from the actual storage of data
  • Keep track of code and storage chunks touched during the execution of a block
  • use only the snapshot for storage
  • change the block format to include proofs + witness
  • "stateless" block execution, solely based on the proof + witness
  • add proof verification for the pre- and post-states during stateless execution

Not included in this PR:

  • tree model switching: verkle trees must be used from the genesis block
  • fast/snap sync: only full sync works

Supersedes #23336

@gballet
verkle: Implement Trie, NodeIterator and Database ifs
d8bfb84
@gballet
Fix crash in TestDump
990a0cc
@gballet
Fix TestDump
e09dc6d
@gballet
Fix TrieCopy
c9a8a63
@gballet
remove unnecessary traces
cd33394
@gballet
fix: Error() returned errIteratorEnd in verkle node iterator
e3b8c1b
@gballet
rewrite the iterator and change the signature of OpenStorageTrie
2743b6c
@gballet
add the adapter to reuse the account trie for storage
5f32bbe
@gballet
don't try to deserialize a storage leaf into an account
4d27208
@gballet
Fix statedb unit tests (#14)
93cf056 
* debug code

* Fix more unit tests

* remove traces

* Go back to the full range
@gballet
One tree to rule them all
762012c
@gballet
remove updateRoot, there is no root to update
2d957b8
@gballet
store code inside the account leaf
cddd657
@gballet
fix build
e4e1ce5
@gballet
save current state for Sina
cf4ea4e
@gballet
Update go-verkle to latest
d1eca8e
@gballet
Charge WITNESS_*_COST gas on storage loads
c633aa2
@gballet
Add witness costs for SSTORE as well
09310c8
@gballet
Charge witness gas in the case of code execution
2e43af8
@gballet
corresponding code deletion
00c1452
@gballet
add a --verkle flag to separate verkle experiments from regular geth …
c710261 
…operations
@gballet
use the snapshot to get data
077f196
@gballet
stateless execution from block witness
26c9f74
@gballet
AccessWitness functions
a960226
@gballet
Add block generation test + genesis snapshot generation
a7656e3
@gballet
test stateless block execution (#18)
fcb4eb1 
* test stateless block execution

* Force tree resolution before generating the proof
@gballet
increased coverage in stateless test execution (#19)
047f87a 
* test stateless block execution

* Force tree resolution before generating the proof

* increase coverage in stateless test execution
@gballet
ensure geth compiles
0499157
@gballet
fix issues in tests with verkle trees deactivated
ce8d9cf
@gballet
Ensure stateless data is available when executing statelessly (#20)
4f0333e 
* Ensure stateless data is available when executing statelessly

* Actual execution of a statless block

* bugfixes in stateless block execution

* code cleanup

 - Reduce PR footprint by reverting NewEVM to its original signature
 - Move the access witness to the block context
 - prepare for a change in AW semantics
   Need to store the initial values.
 - Use the touch helper function, DRY

* revert the signature of MustCommit to its original form (#21)
@gballet
fix leaf proofs in stateless execution (#22)
cbb58dc 
* Fixes in witness pre-state

* Add the recipient's nonce to the witness

* reduce PR footprint and investigate issue in root state calculation

* quick build fix
@gballet
cleanup: Remove extra parameter in ToBlock
28cc5d1
@gballet
revert ToBlock to its older signature
810cb9e
@gballet gballet marked this pull request as ready for review September 22, 2021 17:58
@gballet gballet marked this pull request as draft September 22, 2021 17:59
@gballet gballet mentioned this pull request Sep 23, 2021
Closed
8 tasks
@gballet
Copy link
Member Author

gballet commented Sep 24, 2021

Rebased at #23630

@gballet gballet closed this Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

@lightclient lightclient Awaiting requested review from lightclient lightclient will be requested when the pull request is marked ready for review lightclient is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gballet