Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: fix nonce for pending accounts #24443

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Feb 21, 2022

Fixes #24436

@s1na s1na requested a review from gballet as a code owner February 21, 2022 14:19
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (note for other reviewers: this is exactly what eth.GetTransactionCount does too)

@holiman holiman added this to the 1.10.17 milestone Feb 22, 2022
@holiman holiman merged commit 862f8e9 into ethereum:master Feb 22, 2022
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Feb 23, 2022
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Sep 30, 2022
cp-wjhan pushed a commit to cp-yoonjin/go-wemix that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In GraphQL endpoints, Account’s transactionCount doesn’t take the pending status into account
3 participants