Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/fetcher: if peers never respond, drop them #24652

Merged
merged 1 commit into from Apr 6, 2022
Merged

eth/fetcher: if peers never respond, drop them #24652

merged 1 commit into from Apr 6, 2022

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Apr 6, 2022

Fixes #24623 (comment), though it shouldn't impact the original issue of having sync problems.

@karalabe karalabe added this to the 1.10.18 milestone Apr 6, 2022
holiman
holiman approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit 111a1b7 into ethereum:master Apr 6, 2022
@holiman holiman mentioned this pull request Apr 6, 2022
Closed
@henopied henopied mentioned this pull request May 28, 2022
Closed
@0xsharma 0xsharma mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.18
Development

Successfully merging this pull request may close these issues.

Node stops syncing for a while with err="shutting down" spam in logs
2 participants
@karalabe @holiman