eth/catalyst: make tests less time-sensitive #26201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
approved these changes
Nov 21, 2022
eth/catalyst/api_test.go
Outdated
| @@ -125,19 +131,10 @@ func TestEth2AssembleBlockWithAnotherBlocksTxs(t *testing.T) { | |||
| } | |||
| // This test is a bit time-sensitive, the miner needs to pick up on the | |||
There was a problem hiding this comment.
This comment could be removed imo
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
This makes a couple of sometimes-failing tests less brittle.
MoonShiesty
pushed a commit
to MoonShiesty/go-ethereum
that referenced
this pull request
Aug 30, 2023
This makes a couple of sometimes-failing tests less brittle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a couple of sometimes-failing tests (https://ci.appveyor.com/project/ethereum/go-ethereum/builds/45400713/job/9w748su5x4fv5vj4#L1116) less brittle.
It also removes a seemingly (?) signing/transaction-adding step in one test. @MariusVanDerWijden PTAL if that was needed, as far as I could tell it wasn't. If it indeed is needed, then the test should have some sort of expectation built in on the number of txs in the payloads/blocks.