core: fix state flushing for catalyst mode #26319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooohh ouch. It took a while before I grokked what you meant by "fix state flushing", when I looked at the code. tldr: Our mechanism to flush to disk is based on the elapsed block processing time, as measured by blockchain.gcproc. This mechanism won't work well unless we actually make sure to bump gcproc when processing blocks, which is fixed by this PR. |
|
I have a node running with this patch for almost 30 hours and the accumulated processing time since then is 26 minutes. So basically on this machine a state will be persisted for mainnet every 65+ hours. Was this the case also before? INFO [12-07|21:37:48.494] Deciding to flush time=26m13.570042217s limit=1h0m0s lastWrite=0 chosen=16,135,433 |
|
@s1na Yep. |
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
The gcproc field tracks the amount of time spent processing blocks, and is used to trigger a state flush to disk when a certain threshold is reached. After the merge, single block insertion by CL is the most common source of block processing time, but this time was not added into gcproc.
MoonShiesty
pushed a commit
to MoonShiesty/go-ethereum
that referenced
this pull request
Aug 30, 2023
The gcproc field tracks the amount of time spent processing blocks, and is used to trigger a state flush to disk when a certain threshold is reached. After the merge, single block insertion by CL is the most common source of block processing time, but this time was not added into gcproc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest solution to increase block processing time for all blocks the CL gives us regardless of whether they end up on the canonical chain or not. Alternatively we can track the execution time of each processed block.