Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: reset txpool on sethead #26392

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Dec 29, 2022

This PR sends a HeadChainEvent on SetHead. The txpool will reset the txnoncer on receiving this head chain event.

probably closes #26154 & #20078

(The change to the test is because the setHeadTest now modifies the txpool, so the gas cost for creating the accesslist is too low)

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman
Copy link
Contributor

holiman commented Dec 29, 2022

I tested with the repro gist that @ferranbt posted in #20078, and can confirm that this PR fixes it

@holiman holiman merged commit db82ea2 into ethereum:master Dec 29, 2022
@holiman holiman added this to the 1.11.0 milestone Dec 29, 2022
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
This change sends a HeadChainEvent when SetHead is invoked. The txpool will then reset the txnoncer on receiving the event.
MoonShiesty pushed a commit to MoonShiesty/go-ethereum that referenced this pull request Aug 30, 2023
This change sends a HeadChainEvent when SetHead is invoked. The txpool will then reset the txnoncer on receiving the event.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accounts stuck in weird state after debug_setHead
2 participants