test, cmd/evm, core, core/vm: flag DAO reduction blocks #2715
Conversation
Updated: Sat Jun 18 11:06:08 UTC 2016 |
|
I lost some ETH when I made a bad contract too, can I get a soft-fork flag? |
|
I'm in favor of the soft/hard fork solution. Thank you @obscuren. |
| @@ -100,6 +102,9 @@ func exec(env vm.Environment, caller vm.ContractRef, address, codeAddr *common.A | |||
| } | |||
| } | |||
| env.Transfer(from, to, value) | |||
| if !createAccount && env.Db().GetCodeHash(*codeAddr) == daoHash && value.Cmp(common.Big0) > 0 { | |||
There was a problem hiding this comment.
Not really sure about this value comparison. Doesn't this actually block value transfers into the dao rather than stop funds leaking out of it?
Shouldn't a simpler comparison be to check for dao code match at the top of this method, if matches query the balance, and then query the balance after the end of execution. If the balance went down, set the flag?
|
@krisives This soft fork would only lock up the funds that were taken, it does not give it back to anyone. |
|
@karalabe Agreed, but can I get a soft-fork flag to lock the funds of someone who has my coins because of the smart contract I created didn't perform as I expected? Also I want this flag to be default anyone can turn it off with |
|
@krisives if it collapses the ecosystem, sure ;) |
|
@krisives sure you can get your own soft-fork flag, all you have to do is create it yourself and convince the majority of the community that it's the morally right thing to do. good luck! |
|
Wouldn't it be more neutral to have options: |
|
@krisives again, yes go create it yourself and request people to download it and adopt it. stop your passive aggressive comments here and go do it! |
|
I've seen some people on IRC who bet on Ethereum crashing (shorting), they are willing to pay up to 0.5 BTC for each user who votes for -no-krisives-softfork |
And, of course, the behaviour that forces fork was made default. ¯_(ツ)_/¯ |
|
@papococ I'd rather not flood the project with duplicate pull requests. I just want a default flag that gives me special treatment in the protocol, what's wrong with that? |
|
i mine through Ethpool does anyone know if they are supporting this? If not what pools are? |
|
There is no way to reach consensus here. Just merge it and let others fork the code and set another default value. |
|
@krisives there's nothing wrong with that, just don't request other people to do work for you. if you want that to happen, then make it happen... yourself |
|
Unbelievable how quite some people value absolute idealism higher than a pragmatic solution to a bug that overthrew the whole ecosystem into a huge mess. We should be more flexible at this point of development IMO, we don't even understand the code of the first big Ethereum project ourselves and allow people to put USD 250.000.000 in it... Thanks you for that solution! |
Why is it the default? There is no possibility for the disagreement side to win with this default. |
|
Everyone, please take the political debates back to other forums. This one is meant to discuss code and purely code. Locking conversations for now as it's getting out of hand. |
|
@krisives I have been thinking about this actually. Something like |
|
Please continue the debate here 👍 |
|
The original proposal has changed to be generic. There's no |
|
Would suggest renaming |
| if err != nil { | ||
| return nil, nil, nil, err | ||
| } | ||
|
|
||
| for _, codeHash := range env.CodeHashes { |
There was a problem hiding this comment.
Minor performance suggestion: consider changing env.CodeHashes to map[common.Hash]struct{} and IllegalCodeHashes to an array and loop over IllegalCodeHashes instead, to avoid linear complexity on env.CodeHashes
Probably not very significant but most likely IllegalCodeHashes.length will be 1 and env.CodeHashes.length will be longer - could even be a few thousand for complex txs.
|
Marking code hash for DELEGATECALL too: obscuren#7 |
This implements a generic approach to enabling soft forks by allowing anyone to put in hashes of contracts that should not be interacted from. This will help "The DAO" in their endevour to stop any whithdrawals from any DAO contract by convincing the mining community to accept their code hash.
|
Reowned #2725. |
!!! IMPORTANT: WORK IN PROGRESS. DO NOT USE (YET) !!!
The DAO soft fork that will prevent blocks being accepted that include any value transfer made from the DAO that matches the correct code hash.
The strategy works in such a way that when a user enables mining -- either thru
--mineor the RPC -- it will start to go in a sort of failsafe mode where it will start to ignore transactions and blocks that reduce the DAO's balance.If you disagree with this you can disable the failsafe by setting the
--no-dao-soft-forkflag.FINAL: Ultimately this decision is not ours to make, it's yours. Please try to leave all biases out of your decision making process and act responsibly -- The go-ethereum Team
CHANGED
The original proposal has changed to be generic. There's no
--no-dao-soft-forknor a--yes-dao-soft-fork. There's simply the notion of--illegal-code-hashesthat takes a list of hashes that are placed in "ignore-mode". This will also allow anyone to make a proposal to the majority of the miners to ask them for help for any future possible soft forks by allowing them to ignore blocks that take certain actions undesirable by the community.TASKS