core/txpool: fix isGapped implementation #27404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Thx for the approval @holiman |
rjl493456442
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Thanks for the fix.
// Short circuit if transaction falls within the scope of the pending list
// or matches the next pending nonce which can be promoted as an executable
// transaction afterwards. Note, the tx staleness is already checked in
// 'validateTx' function previously.I would prefer to update the comment above.
dkatzan
force-pushed
the
danielk/txpool-isgapped-fix
branch
from
c2686d5
to
910431b
Compare
|
Thx @rjl493456442 , I have updated the comment |
antonydenyer
pushed a commit
to antonydenyer/go-ethereum
that referenced
this pull request
Jul 28, 2023
This fix a minor implementation issue with the newly introduced isGapped function and it is described in ticket: ethereum#27401
MoonShiesty
pushed a commit
to MoonShiesty/go-ethereum
that referenced
this pull request
Aug 30, 2023
This fix a minor implementation issue with the newly introduced isGapped function and it is described in ticket: ethereum#27401
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This fix a minor implementation issue with the newly introduced isGapped function and it is described in ticket: ethereum#27401
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 210e688.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 210e688.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 210e688.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix a minor implementation issue with the newly introduced isGapped function
and it is described in this ticket: #27401