Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/txpool/legacypool: handle missing head in reset #27479

Merged
merged 1 commit into from Jun 19, 2023
Merged

core/txpool/legacypool: handle missing head in reset #27479

merged 1 commit into from Jun 19, 2023

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jun 15, 2023

Fixes #27301

@karalabe
Copy link
Member

Pls rebase, the txpool package was moved to core/txpool/legacypool.

@holiman holiman added this to the 1.12.1 milestone Jun 16, 2023
@holiman holiman changed the title core/txpool: handle missing head in reset core/txpool/legacypool: handle missing head in reset Jun 16, 2023
karalabe
karalabe approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@fjl fjl merged commit e4660a1 into ethereum:master Jun 19, 2023
1 of 2 checks passed
@lochjin lochjin mentioned this pull request Jul 6, 2023
Merged
spencer-tb pushed a commit to spencer-tb/go-ethereum that referenced this pull request Jul 7, 2023
@holiman @spencer-tb
core/txpool/legacypool: handle missing head in reset (ethereum#27479)
e21da42 
Fixes ethereum#27301, a crash that could occur during txpool reorg handling.
MoonShiesty pushed a commit to MoonShiesty/go-ethereum that referenced this pull request Aug 30, 2023
@holiman @MoonShiesty
core/txpool/legacypool: handle missing head in reset (ethereum#27479)
8357078 
Fixes ethereum#27301, a crash that could occur during txpool reorg handling.
@holiman holiman deleted the txpool_fix branch October 11, 2023 07:27
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@holiman @devopsbo3
core/txpool/legacypool: handle missing head in reset (ethereum#27479)
e9686ce 
Fixes ethereum#27301, a crash that could occur during txpool reorg handling.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core/txpool/legacypool: handle missing head in reset (ethereu…
1a93083 
…m#27479)"

This reverts commit e9686ce.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core/txpool/legacypool: handle missing head in reset (ethereu…
bf8ddb7 
…m#27479)"

This reverts commit e9686ce.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core/txpool/legacypool: handle missing head in reset (ethereu…
6063767 
…m#27479)"

This reverts commit e9686ce.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.

Panic in tx-pool reorg handling
3 participants
@holiman @karalabe @fjl