Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethdb/pebble: upgrade pebble #28070

Merged
merged 2 commits into from Sep 29, 2023
Merged

Conversation

rjl493456442
Copy link
Member

This PR upgrades the pebble dependencies with two features merged:

The intention is not to merge this pull request immediately, but wait a bit more for a stable release from pebble.

@rjl493456442
Copy link
Member Author

Run a snap sync on bench05/06, 05 is the experimental branch.

There is no big difference of the overall system resource comsumption.

截屏2023-09-08 上午11 30 10

Database read/write wise, master is "slightly" higher. But we can treat them as identical.

截屏2023-09-08 上午11 33 51

05 finishes sync a half hour ahead (9 hours in total), not too much difference.

截屏2023-09-08 上午11 35 26

All in all, I don't think pebble changes has a big impact on the snap sync performance. Let's switch to full sync then.

@rjl493456442
Copy link
Member Author

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjl493456442
Copy link
Member Author

rjl493456442 commented Sep 12, 2023

Switch to full sync for a few days, dump some metrics here

Overall system metrics

Not too much difference

截屏2023-09-12 下午7 45 06

Database

This pull request has ~10% disk read, otherwise pretty much same(bench05 is 4 hours ahead)

截屏2023-09-12 下午7 46 39

Sync performance

This pull request is ~3hours a head after running 3 or 4 days. A little faster, but not too much

截屏2023-09-12 下午7 48 18

The conclusion is, with the change of cockroachdb/pebble#2846, a few unnecessary disk reads are avoid.

@karalabe
Copy link
Member

Given the strange IO issues on Pebble 23.1, this branch got a priority merge 🙃

@karalabe karalabe merged commit 22dcb7a into ethereum:master Sep 29, 2023
1 of 2 checks passed
hyunchel pushed a commit to hyunchel/go-ethereum that referenced this pull request Oct 6, 2023
* ethdb/pebble: upgrade pebble

* ethdb/pebble, go.mod: update pebble to master (aa077af62593)

---------

Co-authored-by: Péter Szilágyi <peterke@gmail.com>
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023
* ethdb/pebble: upgrade pebble

* ethdb/pebble, go.mod: update pebble to master (aa077af62593)

---------

Co-authored-by: Péter Szilágyi <peterke@gmail.com>
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 16, 2023
* ethdb/pebble: upgrade pebble

* ethdb/pebble, go.mod: update pebble to master (aa077af62593)

---------

Co-authored-by: Péter Szilágyi <peterke@gmail.com>
0x366 pushed a commit to Dexcelerate/go-ethereum that referenced this pull request Nov 8, 2023
* ethdb/pebble: upgrade pebble

* ethdb/pebble, go.mod: update pebble to master (aa077af62593)

---------

Co-authored-by: Péter Szilágyi <peterke@gmail.com>
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
* ethdb/pebble: upgrade pebble

* ethdb/pebble, go.mod: update pebble to master (aa077af62593)

---------

Co-authored-by: Péter Szilágyi <peterke@gmail.com>
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Jan 16, 2024
* ethdb/pebble: upgrade pebble

* ethdb/pebble, go.mod: update pebble to master (aa077af62593)

---------

Co-authored-by: Péter Szilágyi <peterke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants