eth/catalyst: prefix payload id with version #28246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
force-pushed
the
prefix-payload-id
branch
from
aff8aa5
to
6e6c723
Compare
holiman
reviewed
Oct 10, 2023
lightclient
force-pushed
the
prefix-payload-id
branch
3 times, most recently
from
89d0560
to
05d844c
Compare
|
Why is this still draft? Want to get it merged? |
lightclient
force-pushed
the
prefix-payload-id
branch
from
05d844c
to
3bdaf77
Compare
|
With this PR applied:
|
lightclient
force-pushed
the
prefix-payload-id
branch
from
3bdaf77
to
5bc6878
Compare
|
Please rebase now that #28230 is merged |
lightclient
force-pushed
the
prefix-payload-id
branch
2 times, most recently
from
0ea3c04
to
9a9f549
Compare
|
rebased! |
|
holiman
approved these changes
Jan 23, 2024
lightclient
force-pushed
the
prefix-payload-id
branch
2 times, most recently
from
519ce52
to
190e40a
Compare
…ad can easily fail for payloads not constructed via analogous fcu
…ersion Co-authored-by: lightclient <lightclient@protonmail.io> Co-authored-by: Martin Holst Swende <martin@swende.se>
lightclient
force-pushed
the
prefix-payload-id
branch
from
190e40a
to
96d0aa0
Compare
|
Ah good catch, should be fixed now! |
Dergarcon
pushed a commit
to specialmechanisms/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
GetPayloadVX should only return payloads which match its version. GetPayloadV2 is a special snowflake that supports v1 and v2 payloads. This change uses a a version-specific prefix within in the payload id, basically a namespace for the version number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is built on top of #28230
Technically,
GetPayloadVXshould only return payloads which match its version.GetPayloadV2is a special snowflake that supports v1 and v2 payloads. Originally I thought to either i) plumb the version through the entire building process so when the payload was retrieved in the API request, it would be possible to determine if the call was valid or ii) to ascertain from the payload itself which version it would have been requested through.@holiman had a much better idea, which is to prefix the payload id with the version number. This involved minimal plumbing and pretty straightforward integration in
GetPayloadVX.