Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql: return error if block from>to #28393

Merged
merged 1 commit into from Oct 23, 2023
Merged

graphql: return error if block from>to #28393

merged 1 commit into from Oct 23, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Oct 20, 2023

return error instead of nil if block from > to

@jsvisa
graphql: return error if block from>to
3856c82 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa jsvisa requested a review from s1na as a code owner October 20, 2023 15:01
s1na
s1na approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as per discussion in ethereum/execution-apis#475.

@holiman holiman added this to the 1.13.5 milestone Oct 23, 2023
holiman
holiman approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman merged commit 43e6a3c into ethereum:master Oct 23, 2023
1 of 2 checks passed
@jsvisa jsvisa deleted the graphql-wrong-block-range branch October 23, 2023 23:33
0x366 pushed a commit to Dexcelerate/go-ethereum that referenced this pull request Nov 8, 2023
@jsvisa @0x366
graphql: return error if block from>to (ethereum#28393)
0757fbb 
As per discussion in ethereum/execution-apis#475
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@jsvisa @devopsbo3
graphql: return error if block from>to (ethereum#28393)
c637c84 
As per discussion in ethereum/execution-apis#475
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "graphql: return error if block from>to (ethereum#28393)"
0ebd947 
This reverts commit c637c84.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "graphql: return error if block from>to (ethereum#28393)"
cf2f02c 
This reverts commit c637c84.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "graphql: return error if block from>to (ethereum#28393)"
04cc189 
This reverts commit c637c84.
@BrewTestBot BrewTestBot mentioned this pull request Nov 14, 2023
Merged
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
@jsvisa @Dergarcon
graphql: return error if block from>to (ethereum#28393)
542b543 
As per discussion in ethereum/execution-apis#475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@s1na s1na s1na approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsvisa @holiman @s1na