eth/gasestimator, internal/ethapi: move gas estimator out of rpc #28600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be checked |
Dergarcon
pushed a commit
to specialmechanisms/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gas estimator when added was a very simple piece of code, so we just dumped it into the RPC APIs. Since then, we've made various tweaks to it, and it feels wrong to have logic code sit inside the RPC which should just convert data and call internal stuff.
This PR moves the gas estimator into it's own package. Code that is unrelated to gas estimation and just prepares the data (e.g. RPC overrides) are still kept in their original location. This should be fine because the gas estimator interface was also simplified a lot to allow running it without a live chain and similar crazy constructs.
Fixes #28570