Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: fix nanoseconds/microseconds mismatch in rpc metrics #28649

Merged
merged 1 commit into from Dec 8, 2023
Merged

rpc: fix nanoseconds/microseconds mismatch in rpc metrics #28649

merged 1 commit into from Dec 8, 2023

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Dec 6, 2023 •
edited

Fixes #28619

The rpc/duration/all meter metered in nanoseconds, the individual meter metered in microseconds. This PR changes it so both types uses nanoseconds.

		rpcServingTimer.UpdateSince(start) // <-- Would use nanoseconds (default) 
		updateServeTimeHistogram(msg.Method, answer.Error == nil, time.Since(start)) // <-- Would use microseconds

@holiman holiman requested a review from fjl as a code owner December 6, 2023 12:52
@fjl fjl merged commit 5a45e7a into ethereum:master Dec 8, 2023
2 of 3 checks passed
@fjl fjl added this to the 1.13.6 milestone Dec 8, 2023
GrapeBaBa pushed a commit to optimism-java/shisui that referenced this pull request Dec 10, 2023
@holiman @GrapeBaBa
rpc: fix ns/µs mismatch in metrics (ethereum#28649)
dc666cf 
The rpc/duration/all meter was in nanoseconds, the individual meter in microseconds.
This PR changes it so both of them use nanoseconds.
@dnhn dnhn mentioned this pull request Dec 18, 2023
Merged
Doozers pushed a commit to kilnfi/pgeth that referenced this pull request Dec 22, 2023
@holiman @Doozers
rpc: fix ns/µs mismatch in metrics (ethereum#28649)
4869ba4 
The rpc/duration/all meter was in nanoseconds, the individual meter in microseconds.
This PR changes it so both of them use nanoseconds.
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
@holiman @Dergarcon
rpc: fix ns/µs mismatch in metrics (ethereum#28649)
ae2dd1f 
The rpc/duration/all meter was in nanoseconds, the individual meter in microseconds.
This PR changes it so both of them use nanoseconds.
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Jan 31, 2024
@holiman @zzzckck
rpc: fix ns/µs mismatch in metrics (ethereum#28649)
9badb15 
The rpc/duration/all meter was in nanoseconds, the individual meter in microseconds.
This PR changes it so both of them use nanoseconds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl Awaiting requested review from fjl fjl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.6
Development

Successfully merging this pull request may close these issues.

rpc: mismatch in rpc-metrics all versus individual
2 participants
@holiman @fjl