Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/rawdb: implement in-memory freezer #29135

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

rjl493456442
Copy link
Member

@rjl493456442 rjl493456442 commented Mar 1, 2024

This pull request introduces the in-memory freezer, which implements the ethdb.AncientStore interface.

The in-memory freezer can be used along with in-memory key-value store, acting as a full-functional ephemeral database.

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly nits, overall looking good

core/rawdb/freezer_memory.go Outdated Show resolved Hide resolved
core/rawdb/freezer_memory.go Show resolved Hide resolved
core/rawdb/freezer_memory.go Outdated Show resolved Hide resolved
core/rawdb/freezer_memory.go Show resolved Hide resolved
core/rawdb/freezer_memory.go Outdated Show resolved Hide resolved
core/rawdb/freezer_memory.go Outdated Show resolved Hide resolved
core/rawdb/freezer_memory.go Outdated Show resolved Hide resolved
core/rawdb/freezer_memory.go Show resolved Hide resolved
core/rawdb/freezer_memory.go Outdated Show resolved Hide resolved
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjl493456442 rjl493456442 added this to the 1.14.0 milestone Mar 29, 2024
@holiman holiman modified the milestones: 1.14.0, 1.14.1 Apr 23, 2024
@fjl fjl changed the title all: implement in-memory freezer core/rawdb: implement in-memory freezer Apr 30, 2024
@fjl fjl merged commit f46c878 into ethereum:master Apr 30, 2024
3 checks passed
fjl pushed a commit to fjl/go-ethereum that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants