-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: implement EIP-2935 #29465
base: master
Are you sure you want to change the base?
core: implement EIP-2935 #29465
Conversation
@s1na, pinging you to be aware of some extra changes that happened on Kaustinen after you pulled the work from the other branch, see: gballet#411, which some days after where also updated in the EIP ethereum/EIPs@2b73ecb |
62cf853
to
246b158
Compare
Co-authored-by: Guillaume Ballet <gballet@gmail.com> Co-authored-by: Ignacio Hagopian <jsign.uy@gmail.com>
Updated to the devnet-1 spec changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests submodule change was accidentally pushed to this branch.
We should also deploy it for dev mode |
@rjl493456442 I believe it does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, left a nitpick but no show stopper
@@ -528,3 +531,42 @@ func TestProcessVerkle(t *testing.T) { | |||
} | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to also read the verkle tree to check that the block hashes are there, so that we can make sure that if the stuff changes in the future, we don't forget to test that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added verkle to the test.
Copied over and adapted from https://github.com/gballet/go-ethereum/tree/kaustinen-with-shapella, following the latest changes to the spec: https://eips.ethereum.org/EIPS/eip-2935