Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: implement EIP-2935 #29465

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

core: implement EIP-2935 #29465

wants to merge 16 commits into from
+133 −3

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Apr 5, 2024 •
edited
Loading

Copied over and adapted from https://github.com/gballet/go-ethereum/tree/kaustinen-with-shapella, following the latest changes to the spec: https://eips.ethereum.org/EIPS/eip-2935

holiman
holiman reviewed Apr 8, 2024
View reviewed changes
core/vm/eips.go Outdated Show resolved Hide resolved
gballet
gballet reviewed Apr 9, 2024
View reviewed changes
core/vm/eips.go Outdated Show resolved Hide resolved
miner/worker.go Show resolved Hide resolved
cmd/evm/internal/t8ntool/execution.go Show resolved Hide resolved
@gballet gballet mentioned this pull request Apr 15, 2024
Open
2 tasks
@jsign
Copy link
Contributor

jsign commented Apr 15, 2024

@s1na, pinging you to be aware of some extra changes that happened on Kaustinen after you pulled the work from the other branch, see: gballet#411, which some days after where also updated in the EIP ethereum/EIPs@2b73ecb

holiman
holiman reviewed Apr 18, 2024
View reviewed changes
core/state_processor.go Outdated Show resolved Hide resolved
holiman
holiman reviewed Apr 18, 2024
View reviewed changes
core/state_processor.go Outdated Show resolved Hide resolved
@lightclient lightclient mentioned this pull request Apr 22, 2024
Closed
@lightclient lightclient force-pushed the eip-2935 branch 3 times, most recently from 62cf853 to 246b158 Compare May 13, 2024 09:22
@s1na @gballet
@jsign @lightclient
core: implement eip-2935
20f1d2c 
Co-authored-by: Guillaume Ballet <gballet@gmail.com>
Co-authored-by: Ignacio Hagopian <jsign.uy@gmail.com>
@s1na
Copy link
Contributor Author

s1na commented May 29, 2024

Updated to the devnet-1 spec changes.

jwasinger
jwasinger reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@jwasinger jwasinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests submodule change was accidentally pushed to this branch.

@rjl493456442
Copy link
Member

We should also deploy it for dev mode

@s1na
Copy link
Contributor Author

s1na commented Jun 18, 2024

We should also deploy it for dev mode

@rjl493456442 I believe it does
https://github.com/ethereum/go-ethereum/pull/29465/files#diff-1272116434e5549f278a940767af52ed2d1abc91c44fa04ec48d8835a3774036R599

holiman
holiman reviewed Jun 18, 2024
View reviewed changes
core/state_processor.go Outdated Show resolved Hide resolved
karalabe
karalabe reviewed Jun 18, 2024
View reviewed changes
core/genesis.go Outdated Show resolved Hide resolved
@s1na s1na removed the status:triage label Jul 2, 2024
gballet
gballet approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, left a nitpick but no show stopper

core/state_processor_test.go
@@ -528,3 +531,42 @@ func TestProcessVerkle(t *testing.T) {
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to also read the verkle tree to check that the block hashes are there, so that we can make sure that if the stuff changes in the future, we don't forget to test that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, added verkle to the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe left review comments

@holiman holiman holiman left review comments

@jwasinger jwasinger jwasinger left review comments

@marioevz marioevz marioevz left review comments

@lightclient lightclient lightclient left review comments

@gballet gballet gballet approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

@MariusVanDerWijden MariusVanDerWijden Awaiting requested review from MariusVanDerWijden MariusVanDerWijden is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
prague status:triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@s1na @jsign @rjl493456442 @karalabe @holiman @gballet @jwasinger @marioevz @lightclient