core: deploy EIP-4788 contract in dev mode genesis #29655
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xbeny
changed the title
|
|
s1na
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
LGTM.
Note that with this PR parent beacon root will always be 0x00.000. But IMO it's still better than the undefined behavior of calling a contract that doesn't exist.
For a more meaningful result we should either allow users to set a custom root via API (similar to how we have to withdrawals), or actually produce some block in simulated beacon. I'm inclined to kick this can down the road :)
fjl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev/Private chain setup now supports EIP-4788 at Genesis block.
Took
BeaconRootsCodefrom here and then added toAlloc.Result on console:
> eth.call({ from: eth.accounts[0], input: '0x5f6020818181720f3df6d732807ef1319fb7b8bb8522d0beac024282525afa1460275760205ff35b5f80fd' }) "0x0000000000000000000000000000000000000000000000000000000000000000"Fixes #29539