Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathdb: add bloomfilter for pathdb's difflayer #29868

Closed
wants to merge 3 commits into from

Conversation

fynnss
Copy link

@fynnss fynnss commented May 29, 2024

The PR add bloom filter for pathdb's difflayer to reduce the call depth of node()

highlights:

  • use bloomfilter union to reduce the duration of rebloom. (100ms -> 4ms)

related issues: #29822

@rjl493456442 rjl493456442 self-assigned this May 29, 2024
@rjl493456442
Copy link
Member

rjl493456442 commented Jun 12, 2024

use bloomfilter union to reduce the duration of rebloom. (100ms -> 4ms)

Could you please put this optimization to state snapshot first and we can measure the overall performance difference then?
I guess it's easier to adopt the change there as the first step.

Do you think this pull request is ready for review? I can set up a benchmark to see the performance difference if so.

@fynnss
Copy link
Author

fynnss commented Jun 18, 2024

Could you please put this optimization to state snapshot first and we can measure the overall performance difference then? I guess it's easier to adopt the change there as the first step.

In state snapshot, the process of rebloom is asynchronous, and so it will be no improvement for overall performance.

Do you think this pull request is ready for review? I can set up a benchmark to see the performance difference if so.

Yes, Its ready for review I think.

@fynnss
Copy link
Author

fynnss commented Jun 18, 2024

But I recently notice that this PR(#29991) add hash cache for difflayers and it seems more reasonable than bloomfilter.

So this PR should be closed if PR-29991 merged.

@fynnss fynnss closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants