Align key and ecdsa nonce entropy #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move random entropy functions to new package randentropy * Add function to get n bytes entropy where up to first 32 bytes are mixed with OS entropy sources
Gustav-Simonsson
force-pushed
the
align_key_and_ecdsa_nonce_entropy
branch
from
c908bfa
to
8c056ae
Compare
|
While tests in crypto and secp256k1 works, we should verify the mixing of OS entropy in terms of security - is it guaranteed to never weaken what we get from crypto/rand? Also: I would suggest we move the Sha3 helper function to sha3 package (if it's in crypto it creates a circular dependency between crypto and the new randentropy package) |
| "time" | ||
| ) | ||
|
|
||
| type RandEntropy struct { |
There was a problem hiding this comment.
I suggest we make this an unexported type and export randentropy.Readerand remove the new(randentropy.RandEntropy) from the other files and pass in the Reader directly.
jpeletier
pushed a commit
to epiclabs-io/go-ethereum
that referenced
this pull request
Apr 22, 2018
…_error cmd/swarm: make sure swarm doesnt crash when requested missing hashes
Zergity
added a commit
to Zergity/go-ethereum
that referenced
this pull request
Apr 28, 2020
Prioritize block with random seed by double the normal block weight
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this pull request
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.