Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts/usbwallet/trezor: upgrade to generate with protoc 27.1 #30058

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

jwasinger
Copy link
Contributor

I'm updating these so that we can lint generated files during the CI as part of #30037

@jwasinger jwasinger marked this pull request as ready for review June 24, 2024 03:25
@jwasinger jwasinger requested a review from karalabe as a code owner June 24, 2024 03:25
@jwasinger jwasinger marked this pull request as draft June 24, 2024 03:26
@jwasinger jwasinger marked this pull request as ready for review June 25, 2024 12:17
jwasinger added a commit to jwasinger/go-ethereum that referenced this pull request Jun 27, 2024
…thereum#30058):  remove some debug statements, fix issue with archive extract deleting target dir, install protoc-gen-go command.
@fjl fjl added this to the 1.14.6 milestone Jul 1, 2024
@fjl
Copy link
Contributor

fjl commented Jul 1, 2024

I couldn't get the connection with a test wallet to work and thus couldn't fully test this. However, I have verified that the encoded packets look the same as with the older encoder version.

@fjl fjl merged commit a4e338f into ethereum:master Jul 1, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants