miner: copy pending state so we don't accidentally modify it #3162
Conversation
|
@Arachnid, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zsfelfoldi, @karalabe and @fjl to be potential reviewers. |
| @@ -74,7 +74,7 @@ func (b *EthApiBackend) StateAndHeaderByNumber(blockNr rpc.BlockNumber) (ethapi. | |||
| // Pending state is only known by the miner | |||
| if blockNr == rpc.PendingBlockNumber { | |||
| block, state := b.eth.miner.Pending() | |||
| return EthApiState{state}, block.Header(), nil | |||
| return EthApiState{state.Copy()}, block.Header(), nil | |||
There was a problem hiding this comment.
The copy can also be made in miner.Pending() itself. That would prevents similar errors when other parts of the code base try to (mis)use the pending state.
There was a problem hiding this comment.
It seems it is making a copy there. I can't explain why that doesn't fix the issue, only confirm that adding the copy here definitely does.
There was a problem hiding this comment.
It makes only a copy when the node is mining. Otherwise it doesn't. I'm not sure why this distinction was made in the past.
There was a problem hiding this comment.
Good spotting. I've fixed the miner instead.
fjl
changed the title
No description provided.