Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TreeConfig to handle trees with different sizes #15

Merged
merged 7 commits into from
Apr 8, 2021

Conversation

gballet
Copy link
Member

@gballet gballet commented Apr 2, 2021

This is so that 1024- and 256-width trees can easily be compared.

Copy link
Collaborator

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bls.MulModFr(&tmp, &powR, &quotients[i])
bls.AddModFr(&g[i], &g[i], &tmp)
}

// rⁱ⁺¹ = r ⨯ rⁱ
bls.MulModFr(&powR, &powR, &r)
}
d = bls.LinCombG1(lg1, g[:])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed LinCombG1 is being used here. Wondering if the same trick for switching algorithms could help here too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most likely 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let me take this back: g is calculated on the evaluation basis, so it's unlikely that any coefficient will be zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants