update (Des|S)erializeProof to the electra proof format #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
force-pushed
the
electra-proof-format
branch
from
8833be2
to
c1093a3
Compare
* fix: add custom JSON serializers * move marshallers to their own file
#331) * fix stem serialization * add a 0x prefix to hex strings * fix: set currentValue to null for a missing key * fix: lowercase for IPAProof in json payload
gballet
force-pushed
the
electra-proof-format
branch
from
63a25b5
to
0b59b1f
Compare
gballet
commented
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at using the new electra proof format.
It still uses the intermediate
Proofstructure, which was used to deserialize the binary proof format. The final version of this code should remove this intermediate step entirely. But this change is already complex enough to warrant an intermediate step. Nonetheless, it this new proof format would simplifyTreeFromProofas there is no longer a need to go over multiple keys with the same stem.