Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo of NewLeafNodeWithNoComms() #417

Closed
wants to merge 1 commit into from
Closed

fix: typo of NewLeafNodeWithNoComms() #417

wants to merge 1 commit into from

Conversation

agnxsh
Copy link
Contributor

@agnxsh agnxsh commented Nov 17, 2023

@agnxsh agnxsh closed this Nov 24, 2023
@jsign
Copy link
Collaborator

jsign commented Nov 24, 2023

@agnxsh, I think this PR was correct?

Actually, this makes me realize this is an API that I'd like not to be public -- feels to brittle. Anyway, that's another topic.

@agnxsh
Copy link
Contributor Author

agnxsh commented Nov 24, 2023

@agnxsh, I think this PR was correct?

Actually, this makes me realize this is an API that I'd like not to be public -- feels to brittle. Anyway, that's another topic.

oh sorry for closing it, i thought it was a trivial change, just caught my eye while going through the codebase, i can make a pr again

@agnxsh
Copy link
Contributor Author

agnxsh commented Nov 24, 2023

#420 here's the revised pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agnxsh @jsign