Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add random tree operation tests #419

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Conversation

weiihann
Copy link
Contributor

This PR adds a random tree operation test case, referring Geth's TestRandom implementation. Minor modifications are as follows:

  • only 32 bytes of random keys are created
  • omitting opItercheckhash and opNodeDiff, can add them once the functionalities are ready

Copy link
Collaborator

@jsign jsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Left some comments for your consideration.

If you can please take a look at the CI lints, there're a couple of things to fix that are quite easy. You can run the linter locally by running go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.2 run if helps.

After the changes I can re-review again to approve.

tree_test.go Show resolved Hide resolved
tree_test.go Outdated Show resolved Hide resolved
tree_test.go Outdated Show resolved Hide resolved
tree_test.go Show resolved Hide resolved
tree_test.go Outdated Show resolved Hide resolved
tree_test.go Outdated Show resolved Hide resolved
tree_test.go Outdated Show resolved Hide resolved
add new module

some fixes
@jsign jsign merged commit d193f0b into ethereum:master Nov 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants