Fix Delete(...) early return #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lure Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
commented
Jan 17, 2024
| break | ||
| return false, nil |
There was a problem hiding this comment.
While breaking was reasonable, the right thing is to return false. Only break would mean L625 being executed signaling that a node deletion should happen, when that shouldn't be the case.
| @@ -1806,3 +1806,36 @@ func TestRandom(t *testing.T) { | |||
| t.Fatal(err) | |||
| } | |||
| } | |||
|
|
|||
| func TestRandomExtracted(t *testing.T) { | |||
There was a problem hiding this comment.
So after a while of debugging TestRandom(...) I extracted (and manually "minified") a simple test that surfaced the bug. Leaving the test here to avoid regressions.
Interestingly, this bug wasn't affecting this other test that was targeting this API.
gballet
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that appeared once in a while in the
TestRandom(...)tests.