This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
Plugin details #98
Merged
Plugin details #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm I'm getting some weird behavior. Plugin Details section is blank. Plugin Code section loads blank, but if I click on it, then it loads (but scrolled all the way to the bottom)
|
|
Fixed the empty state @ryanio. Also seeing no results in plugin details though. Investigating. |
|
Ah, discovered metadata only available for remote registry plugins. I've removed the "Plugin Details" title when there is no metadata to display. If there is work to be done to display metadata of local plugins, let's open a new ticket for that. |
evertonfraga
added a commit
that referenced
this pull request
Jul 22, 2019
* fix: refactor VersionList (#80) * ci: disabling nightly builds (#87) * fix: height 100% for apps (#88) * fix: height 100% for apps * fix: height fix when showing url bar * test: add timestamp of last loaded time to versionlist * fix: do not open local server on browser (#92) * feat: expands showOpenDialog to accept `file` or `directory` (#90) * feat: expands showOpenDialog to accept `file` or `directory` (or `file_multiple`, `directory_multiple`) * fix: bool console warnings * chore: update `openDirectory` param to `pathType` * feat: Terminal Input (#94) * feat: terminal input * chore: show 'No logs yet.' message instead of blank terminal * feat: scroll through terminal input history on up arrow and down arrow * feat: plugin list categories (#97) * feat: custom settable flags (#95) * feat: custom settable flags * fix: lint * fix: tests * feat: persist config data (#93) * feat: persist config data * feat: rehydrate settings from config.json * fix: remove redux-persist cruft * fix: function purity * feat: persists plugin selection * fix: listSubheader material-ui warning (#99) * fix: listSubheader material-ui warning * fix: remove extraneous key * feat: protect terminal input (#96) * feat: protect terminal input * chore: update label to 'Hide input' * Plugin details (#98) * add codemirror * rename "nodes" to "plugins" * feat: add plugin view * fix: empty loads and warnings * fix: hide title if no metadata * chore: update theme (#101) * chore: update theme * fix: colors as constants * chore: use newState event (#89) * chore: use newState event * chore: use newState event * fix: run `onConnect` on `connected` * fix: watchForPeers only on client.type === 'client' * chore: move block subscriptions to own method to not clutter onConnect method * chore: update pluginError event name (#102) * chore: update pluginError event name * fix: update removeListeners event name * chore(deps): bump lodash.template from 4.4.0 to 4.5.0 (#103) Bumps [lodash.template](https://github.com/lodash/lodash) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.4.0...4.5.0) Signed-off-by: dependabot[bot] <support@github.com> * fix: watchForPeers fix * feat: component-scoped UI (#100) * feat: start with component & client scope * fix: add simplified config generator * fix: change entry point of scoped view to config * feat: allows nano to open grid-ui * fix: createListeners for all plugins * fix: disables toggle btns * feat: start with component & client scope * fix: add simplified config generator * fix: change entry point of scoped view to config * feat: allows nano to open grid-ui * fix: createListeners for all plugins * fix: disables toggle btns * fix: capture flags in config.json * feat: scoped apps rendering * add xterm * fix: restore toggle * fix: remove cruft * feat: Dark mode (#107) * feat: first iteration of dark theme * fix: lint rule exception * chore: pass themeMode via props so that grid-ui can be opened with args.scope.themeMode = 'dark' or 'light'. defaults to 'dark' * feat: open tabs dynamically (#106) * feat: open tabs dynamically * fix: resume state correctly * fix: pass clientName correctly to set custom flags (#108)
evertonfraga
pushed a commit
that referenced
this pull request
Jul 26, 2019
* add codemirror * rename "nodes" to "plugins" * feat: add plugin view * fix: empty loads and warnings * fix: hide title if no metadata
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Any helpful background information?
From a security standpoint it is important to have information about the plugin. What does it do? Is it coming from a trusted source? Is it the correct plugin or is it pointing to a wrong local location? ...
The editor could be the foundation to write custom plugins or edit existing ones (dev only) from within Grid.
New dependencies? What are they used for?
Pluginin GridRelevant screenshots?
Does it close any issues?
ethereum/grid#298
ethereum/grid#287