Change interpret to take vm arg instead of StateT #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcz
force-pushed
the
interpreters
branch
4 times, most recently
from
6f76ecb
to
93b607c
Compare
|
@d-xo This is ready. While waiting for tests, I also did some cleanup to the modules I was touching. |
|
Not sure why the macos tests didn't pass after the last commit, I can't reproduce that locally |
|
Looks like a failure from our differential fuzz testing harness vs geth, can also repro on main, filed an issue here and reran failed ci jobs. |
d-xo
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This simplifies the code a bit and reduces peak memory on ethereum-tests from ~10G to ~9G.
Checklist