add to_0x_hex method to easily create 0x-prefixed strings #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
add-to_0x_hex-method
branch
from
011f5e3
to
e56442c
Compare
pacrob
force-pushed
the
add-to_0x_hex-method
branch
from
e56442c
to
35a0e81
Compare
reedsa
reviewed
Mar 19, 2024
| """ | ||
| Convert the bytes to a 0x-prefixed hex string | ||
| """ | ||
| return "0x" + self.hex() |
There was a problem hiding this comment.
Not sure if the hexbbytes object is guarunteed to store without the prefix? Should this ensure the 0x is not already part of the string?
There was a problem hiding this comment.
As it's just a bytes object at the core, there would be no 0x from there. Previously the .hex() method returned an 0x prefix, but does not anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
In PR #38, I changed the function of the
.hex()method to drop the0x-prefix to match the parentbytesclass. But it turns out some other libs depend on there being a quick method to render an 0x-prefixed string.How was it fixed?
Added the
to_0x_hex()method to provide the same functionality.hex()used to have, but more explicitly.Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture