Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pre-Merge Tests from simulators/eth2/engine, simulators/ethereum/engine #783

Closed
2 of 4 tasks
marioevz opened this issue May 16, 2023 · 1 comment · Fixed by #838
Closed
2 of 4 tasks

Remove Pre-Merge Tests from simulators/eth2/engine, simulators/ethereum/engine #783

marioevz opened this issue May 16, 2023 · 1 comment · Fixed by #838

Comments

@marioevz
Copy link
Member

marioevz commented May 16, 2023

Pre-Merge tests are no longer relevant to the clients and some of them are actively removing code related to Proof-of-work, clique, and other pre-PoS consensus algorithms.

These tests will eventually fail for all clients due to the code removal, so it's just appropriate to remove them from all simulators, to reduce run time, and simplify test code in general.

Tasks

More details:

  • simulators/ethereum/engine/suites/engine/tests.go
    • All Invalid Transition tests must be removed since they all start from Pre-Merge and tests the PoW->PoS transition
    • If a test verifies that invalid payloads are rejected, they should test the scenario on a purely PoS environment
    • TTD must be zero for all tests.
  • Test suite simulators/ethereum/engine/suites/transition should be removed entirely.
@marioevz
Copy link
Member Author

marioevz commented Oct 3, 2023

Bullet point 4 was completed by #840

Bullet points 2 and 3 will be completed by #838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant