Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulators/eth2/dencun: Dencun Interop Simulator and Builder Tests #838

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Sep 4, 2023

Changes included

Linked Issues

ToDos:

  • Add proper verifications to blob transactions on the Execution chain and then on the beacon Beacon using the Beacon API
    • Verify KZG commitments on beacon block against blob sidecars
    • Cross-compare blob sidecars between multiple clients
    • Compare KZG commitments against execution payload header
  • Add sync tests starting on Deneb with a chain that includes blobs
    • Start chain from Capella, upgrade to deneb, send blobs, wait an epoch, then start client to sync
    • Start chain from Deneb, send blobs, wait an epoch, then start client to sync
  • Add Re-Org tests starting on Deneb with N nodes on M different chains containing different blobs, wait for clients to reach canonical chain consensus
    • Start chain from Capella, upgrade to deneb, send blobs, wait an epoch, then start client to sync
    • Start chain from Deneb, send blobs, wait an epoch, then start client to sync
  • Add builder tests corrupting: blob gas used, excess blob gas

Examples

Run builder tests

cl=lighthouse; ./hive --client-file ./configs/cancun.yaml --client go-ethereum,${cl}-bn,${cl}-vc --sim eth2/dencun" --sim.limit "eth2-deneb-builder/"

Run sync tests

cl=lighthouse; ./hive --client-file ./configs/cancun.yaml --client go-ethereum,${cl}-bn,${cl}-vc --sim eth2/dencun" --sim.limit "eth2-deneb-sync/"

Run re-org tests

cl=lighthouse; ./hive --client-file ./configs/cancun.yaml --client go-ethereum,${cl}-bn,${cl}-vc --sim eth2/dencun" --sim.limit "eth2-deneb-reorg/"

@marioevz marioevz force-pushed the eth2-dencun branch 4 times, most recently from b046ad2 to 6dc7d59 Compare September 25, 2023 18:11
@marioevz marioevz changed the title [WIP] simulators/eth2/dencun: Dencun Interop Simulator and Builder Tests simulators/eth2/dencun: Dencun Interop Simulator and Builder Tests Oct 2, 2023
@marioevz marioevz marked this pull request as ready for review October 2, 2023 15:32
@marioevz marioevz marked this pull request as draft October 4, 2023 01:06
@marioevz
Copy link
Member Author

marioevz commented Oct 4, 2023

Changed back to draft because it requires changes in #898, and they might not even be included in master until we find a proper solution.

@marioevz
Copy link
Member Author

I rebased and squashed most of the commits to be able to merge using a merge commit, so we preserve the multiple commits in the master branch.

I'm running locally tonight and should be able to merge tomorrow if all is good.

@marioevz marioevz force-pushed the eth2-dencun branch 3 times, most recently from 49d2cf0 to 3c48ac1 Compare March 4, 2024 15:04
@marioevz marioevz merged commit 0d3ca4e into ethereum:master Mar 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Pre-Merge Tests from simulators/eth2/engine, simulators/ethereum/engine
1 participant