Skip to content

Commit

Permalink
Bump version: 0.14.5 → 0.14.6
Browse files Browse the repository at this point in the history
  • Loading branch information
pipermerriam committed Nov 19, 2019
1 parent 1e1bd5f commit 19334b5
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .bumpversion.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 0.14.5
current_version = 0.14.6

This comment has been minimized.

Copy link
@cburgdorf

cburgdorf Nov 20, 2019

Contributor

@pipermerriam This should probably have bumped to 0.15.0 because now it broke older Trinity versions. You can not install v0.1.0-alpha.29 because of this. You'll run into:

ERROR: lahja 0.14.6 has requirement trio<0.14,>=0.13, but you'll have trio 0.11.0 which is incompatible.

In an ideal world, someone should be able to install Trinity v0.1.0-alpha.29 5 years from now and just be able to run it.

I think when in doubt, we should default to bump the minor part and only bump the patch part if we can absolutely be sure that this won't break anything. In this case it broke old Trinity releases because the trio dependency jumped to a new minor version.

Another alternative would be to pin lahja in Trinity to a specific version (but that would still mean breaking potential other apps that use lahja under the assumption that patch updates won't break anything.

This comment has been minimized.

Copy link
@pipermerriam

pipermerriam Nov 20, 2019

Author Member

🤦‍♂️ I looked at the other release notes to see if there was anything breaking but I failed to realize that the trio update itself was breaking. Thanks for catching this.

I think I'm inclined to recreate the patch release without the trio bump and then make a new minor release. I'll do that today if there are no strong objections.

This comment has been minimized.

Copy link
@cburgdorf

cburgdorf Nov 20, 2019

Contributor

think I'm inclined to recreate the patch release without the trio bump and then make a new minor release. I'll do that today if there are no strong objections.

I wasn't aware that pypi let's you replace versions but if it does then I agree that is probably the best way to handle it.

commit = True
tag = True
parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(-(?P<stage>[^.]*)\.(?P<devnum>\d+))?
Expand Down
18 changes: 18 additions & 0 deletions docs/release_notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,24 @@ Release Notes

.. towncrier release notes start
Lahja 0.14.6 (2019-11-19)
-------------------------

Features
~~~~~~~~

- Ensure ``stream()`` does not suppress ``CancelledError`` (`#156 <https://github.com/ethereum/lahja/issues/156>`__)
- Use the highest available `pickle` protocol. This yields a notable performance
improvement on Python < 3.8 which are still using version 3 of the protocol by
default. (`#160 <https://github.com/ethereum/lahja/issues/160>`__)


Misc
~~~~

- `#163 <https://github.com/ethereum/lahja/issues/163>`__


Lahja 0.14.5 (2019-09-10)
-------------------------

Expand Down
1 change: 0 additions & 1 deletion newsfragments/156.feature.rst

This file was deleted.

3 changes: 0 additions & 3 deletions newsfragments/160.feature.rst

This file was deleted.

1 change: 0 additions & 1 deletion newsfragments/163.misc.rst

This file was deleted.

2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
setup(
name='lahja',
# *IMPORTANT*: Don't manually change the version here. Use `make bump`, as described in readme
version='0.14.5',
version='0.14.6',
description="Generic event bus for asynchronous cross-process communication",
long_description=long_description,
long_description_content_type='text/markdown',
Expand Down

0 comments on commit 19334b5

Please sign in to comment.