-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
[bumpversion] | ||
current_version = 0.14.5 | ||
current_version = 0.14.6 | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
pipermerriam
Author
Member
|
||
commit = True | ||
tag = True | ||
parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(-(?P<stage>[^.]*)\.(?P<devnum>\d+))? | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
@pipermerriam This should probably have bumped to
0.15.0
because now it broke older Trinity versions. You can not installv0.1.0-alpha.29
because of this. You'll run into:In an ideal world, someone should be able to install Trinity
v0.1.0-alpha.29
5 years from now and just be able to run it.I think when in doubt, we should default to bump the
minor
part and only bump thepatch
part if we can absolutely be sure that this won't break anything. In this case it broke old Trinity releases because thetrio
dependency jumped to a newminor
version.Another alternative would be to pin
lahja
in Trinity to a specific version (but that would still mean breaking potential other apps that uselahja
under the assumption thatpatch
updates won't break anything.