Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure internal events aren't pushed into central event bus #10

Closed
cburgdorf opened this issue Sep 21, 2018 · 0 comments
Closed

Ensure internal events aren't pushed into central event bus #10

cburgdorf opened this issue Sep 21, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@cburgdorf
Copy link
Contributor

cburgdorf commented Sep 21, 2018

What was wrong?

Currently, even if we would broadcast an event only to our very own Endpoint it will still go on a roundtrip to the EventBus (which usually should sit in another process) which is

a.) a waste of resources

b.) restricts use case to pickable events

If we would short circuit internal events to stay within the Endpoint we could get rid of the special legacy PluginManager events in Trinity and handle those via the event bus as well.

How can it be fixed?

Detect internal events and ensure they stay within the Endpoint.

@cburgdorf cburgdorf added the enhancement New feature or request label Sep 21, 2018
@cburgdorf cburgdorf changed the title Ensure domestic events aren't pushed into central event bus Ensure internal events aren't pushed into central event bus Sep 27, 2018
cburgdorf added a commit to cburgdorf/lahja-1 that referenced this issue Sep 27, 2018
cburgdorf added a commit to cburgdorf/lahja-1 that referenced this issue Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant