Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the highest available pickle protocol #160

Merged

Conversation

cburgdorf
Copy link
Contributor

@cburgdorf cburgdorf commented Sep 26, 2019

What was wrong?

On Python < 3.8 (which isn't released yet) pickle still uses version 3 of the protocol by default (even though version 4 is already available. Python 3.8 will make version 5 the default protocol.

How was it fixed?

Always use the highest available pickle protocol.

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@cburgdorf cburgdorf force-pushed the christoph/fix/pickle-latest-protocol branch 2 times, most recently from d435076 to 02306be Compare September 26, 2019 20:26
Copy link
Member

@pipermerriam pipermerriam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

@cburgdorf cburgdorf merged commit 4bfd376 into ethereum:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants