[WIP] Trio based implementation of the Endpoint API #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pytest-dev/pytest-asyncio#125 if accepted and released would allow us to condense the test runs back down. |
pipermerriam
force-pushed
the
piper/mirrored-trio-endpoint
branch
from
347b742
to
5cf6354
Compare
pipermerriam
commented
May 14, 2019
lahja/_utils.py
Outdated
| import time | ||
|
|
||
|
|
||
| async def wait_for_path(path: pathlib.Path, timeout: int=2) -> None: |
There was a problem hiding this comment.
TODO: I can extract this change out of this PR
| from lahja.trio.endpoint import TrioEndpoint | ||
|
|
||
|
|
||
| class BaseBackend(ABC): |
There was a problem hiding this comment.
TODO: extract this into a standalone PR to reduce scope of this PR
lahja/trio/endpoint.py
Outdated
| msg_data = pickle.dumps(message) | ||
| size = len(msg_data) | ||
| await self._socket.send_all(size.to_bytes(4, 'little')) | ||
| await self._socket.send_all(msg_data) |
There was a problem hiding this comment.
probably cheaper to combine these into a single send over the socket?
lahja/trio/endpoint.py
Outdated
| if msg_size_data == b'': | ||
| # probably in the process of being cancelled... | ||
| await trio.hazmat.checkpoint() | ||
| raise EOFError |
There was a problem hiding this comment.
I think this should probably be converted to an internal lahja exception.
lahja/trio/endpoint.py
Outdated
| raise Exception("TODO: stream closed") | ||
| if len(msg_data) != msg_size: | ||
| # probably in the process of being cancelled... | ||
| await trio.hazmat.checkpoint() |
There was a problem hiding this comment.
TODO: I think this can be removed. as well as the other ones.
pipermerriam
force-pushed
the
piper/mirrored-trio-endpoint
branch
3 times, most recently
from
0656050
to
157f41b
Compare
This was referenced May 24, 2019
Merged
pipermerriam
force-pushed
the
piper/mirrored-trio-endpoint
branch
from
dde8b75
to
75e1d3e
Compare
pipermerriam
force-pushed
the
piper/mirrored-trio-endpoint
branch
from
75e1d3e
to
9496b5e
Compare
pipermerriam
force-pushed
the
piper/mirrored-trio-endpoint
branch
from
9496b5e
to
10d26b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by #88
What was wrong?
WIP
Ugly things:
pytest-asynciodoesn't play nice in the test suite so I ended up having to segregate them.How was it fixed?
Summary of approach.
Cute Animal Picture