This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Commented out parameter name for copy-constructor for secure_vector #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class to work around GCC bug which is marked as fixed in GCC-4.9.0. The compiler issues a warning about the named parameter not being used within synthesized code. The warning is obviously not very useful. The parameter *is* used, but the name is not used, because the code is synthesized.
This is a workaround for the warning, which breaks the build on certain systems because warnings-as-errors is enabled.
http://stackoverflow.com/questions/12793412/defaulted-copy-constructor-and-copy-assignment-assignment-operator-giving-strang
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57211
bobsummerwill
added a commit
to doublethinkco/cpp-ethereum-cross
that referenced
this pull request
Dec 30, 2015
|
Thanks a lot! |
chriseth
added a commit
that referenced
this pull request
Jan 5, 2016
Commented out parameter name for copy-constructor for secure_vector
|
Np. Easy fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented out parameter name for copy-constructor for secure_vector<> class to work around GCC bug which is marked as fixed in GCC-4.9.0. The compiler issues a warning about the named parameter not being used within synthesized code. The warning is obviously not very useful. The parameter is used, but the name is not used, because the code is synthesized.
This is a workaround for the warning, which breaks the build on certain systems because warnings-as-errors is enabled.
http://stackoverflow.com/questions/12793412/defaulted-copy-constructor-and-copy-assignment-assignment-operator-giving-strang
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57211